Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tab page ads should adhere to frequency caps #11594

Merged
merged 3 commits into from
Dec 14, 2021
Merged

New tab page ads should adhere to frequency caps #11594

merged 3 commits into from
Dec 14, 2021

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Dec 14, 2021

Resolves brave/brave-browser#20089

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Confirm users are rewarded for viewing new tab page ads
  • Confirm users are not rewarded for viewing new tab page ads if:
    • catalog has not downloaded
    • catalog has expired (older than 1 day)
    • there are no issuers
    • there are less than 10 unblinded tokens
    • exceeded 4 ads per hour (unless overridden by griffin)
    • exceeded 20 ads per day (unless overridden by griffin)

@tmancey tmancey self-assigned this Dec 14, 2021
@tmancey tmancey merged commit 6a3100c into master Dec 14, 2021
@tmancey tmancey deleted the issues/20089 branch December 14, 2021 18:47
@tmancey tmancey added this to the 1.35.x - Nightly milestone Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New tab page ads should adhere to frequency caps
3 participants