Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a switch to enable / disable WebTorrent in settings #1218

Merged
merged 3 commits into from
Jan 4, 2019

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Jan 4, 2019

This is a PR credited to @yrliou
I just rebased it and fixed up tests.

Fix brave/brave-browser#897

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@bbondy bbondy added the 0.61.x label Jan 4, 2019
@bbondy bbondy self-assigned this Jan 4, 2019
@bbondy bbondy requested a review from emerick January 4, 2019 20:47
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbondy
Copy link
Member Author

bbondy commented Jan 4, 2019

Disclaimer: I reviewed code as well since I'm not the author.

@bbondy bbondy merged commit d675130 into master Jan 4, 2019
bbondy added a commit that referenced this pull request Jan 4, 2019
Provide a switch to enable / disable WebTorrent in settings
bbondy added a commit that referenced this pull request Jan 4, 2019
Provide a switch to enable / disable WebTorrent in settings
@bbondy bbondy added this to the 0.61.x - Nightly milestone Jan 14, 2019
@bsclifton bsclifton deleted the webtorrent-switch-0.61.x branch January 24, 2019 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a switch to enable / disable WebTorrent in settings
3 participants