Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes for Android EVM networks feature #12204

Merged
merged 2 commits into from
Feb 10, 2022

Conversation

SergeyZhukovsky
Copy link
Member

Resolves brave/brave-browser#20968
Resolves brave/brave-browser#20962
Resolves brave/brave-browser#20967
Resolves brave/brave-browser#20977

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@SergeyZhukovsky SergeyZhukovsky added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Feb 10, 2022
@SergeyZhukovsky SergeyZhukovsky self-assigned this Feb 10, 2022
Copy link

@Pavneet-Sing Pavneet-Sing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@@ -68,7 +68,7 @@
mListener = listener;
}

protected void updateNetworkInfo(EthereumChain item) {
protected void updateNetworkInfo(EthereumChain item, boolean activeNetwork) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe protected can be removed, unless we wanna inherit from RowViewHolder.

Copy link
Contributor

@wchen342 wchen342 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:+1:

@srirambv
Copy link
Contributor

srirambv commented Feb 11, 2022

Verification passed on Oppo Reno 5 with Android 12 running 1.37.42 x64 Nightly build

Verified brave/brave-browser#20968

  • Verified URL's is replaced with URL

Verified brave/brave-browser#20977

20977.mp4

Verified brave/brave-browser#20967

  • Verified when a custom network is set as active, editing the chain ID doesn't remove it
  • Encountered #21046 & #21047
20967.mp4

@Uni-verse
Copy link
Contributor

Uni-verse commented Feb 11, 2022

brave/brave-browser#20962 has been verified

Completed using Nightly 1.37.42, Chromium 98.0.4758.87
Device: Samsung GS 21 | Android 12

  • Button text has enough padding around it.

Screenshot_20220211-232400_Brave - Nightly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
5 participants