-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fixes for Android EVM networks feature #12204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
@@ -68,7 +68,7 @@ | |||
mListener = listener; | |||
} | |||
|
|||
protected void updateNetworkInfo(EthereumChain item) { | |||
protected void updateNetworkInfo(EthereumChain item, boolean activeNetwork) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: maybe protected can be removed, unless we wanna inherit from RowViewHolder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM:+1:
Verification passed on Oppo Reno 5 with Android 12 running 1.37.42 x64 Nightly build Verified brave/brave-browser#20968 Verified brave/brave-browser#20977
20977.mp4Verified brave/brave-browser#20967
20967.mp4 |
brave/brave-browser#20962 has been verified Completed using Nightly
|
Resolves brave/brave-browser#20968
Resolves brave/brave-browser#20962
Resolves brave/brave-browser#20967
Resolves brave/brave-browser#20977
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: