Remove refcode field from P3A messages #12478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always rewrite the `refcode` metadata field attached to P3A reports to "none". We no longer need this analysis column for P3A questions so we shouldn't collect it. We continue to report a value as part of the metadata string to avoid imposing a format change on the analysis back-end code.
We no longer need to report this field, so remove it from the dict submitted in json format entirely.
DJAndries
approved these changes
Mar 3, 2022
iefremov
reviewed
Mar 7, 2022
| const std::string& country = meta->country_code; | ||
| constexpr char kRefcodeNone[] = "none"; | ||
| constexpr char kCountryOther[] = "other"; | ||
| constexpr char kRefcodeOther[] = "other"; | ||
|
|
||
| static base::flat_set<std::string> const kLinuxCountries( | ||
| {"US", "FR", "DE", "GB", "IN", "BR", "PL", "NL", "ES", "CA", "IT", "AU", |
There was a problem hiding this comment.
we probably could revise the other lists as well, most probably things changed since 2018 :)
iefremov
approved these changes
Mar 7, 2022
25 tasks
rillian
added a commit
that referenced
this pull request
Mar 7, 2022
When the refcode field was removed, special-case logic which allowed the reporting the "US" country code as part of P3A message metadata was unintentionally removed. Since the US has many users, it's useful to segment usage data by that region, and there is no privacy advantage to stripping that country code. Follow up to #12478
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop reporting refcode with P3A messages since we don't need it for analysis
nonein the protobuf metadata string so there's something for the backend to parseResolves brave/brave-browser#21460
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
Examine P3A network traffic from the browser
nonein the refcode field, which is the second-to-last comma-separated value at the end of the base64-coded measurement string.refcodefield at all.To test a fresh profile:
To test an established profile