Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): add reset transaction & nonce setting #12493

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

Pavneet-Sing
Copy link

@Pavneet-Sing Pavneet-Sing commented Mar 4, 2022

Resolves brave/brave-browser#21457

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Follow same test plan as iOS

Note:

  • Approved copies are from iOS and dialog style is from desktop.

Screenshots:

Dialog Setting
Screenshot from 2022-03-05 04-06-49 Screenshot from 2022-03-05 04-06-10

@Pavneet-Sing Pavneet-Sing added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Mar 4, 2022
@Pavneet-Sing Pavneet-Sing self-assigned this Mar 4, 2022
@Pavneet-Sing Pavneet-Sing force-pushed the 21457-option-to-reset-transactiion-and-nonce branch from 03fc56d to 30b706e Compare March 7, 2022 11:29
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@Pavneet-Sing Pavneet-Sing merged commit b8111bf into master Mar 9, 2022
@Pavneet-Sing Pavneet-Sing deleted the 21457-option-to-reset-transactiion-and-nonce branch March 9, 2022 09:59
@Pavneet-Sing Pavneet-Sing added this to the 1.38.x - Nightly milestone Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a way to reset local transaction / nonce information (android)
2 participants