Prevent loading brave scheme url from javascript #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent loading brave scheme url from javascript
bridiver
reviewed
Jan 8, 2019
| // Web UI bindings need the ability to request chrome: URLs. | ||
| state->second->GrantRequestScheme(kChromeUIScheme); | ||
| +#if defined(BRAVE_CHROMIUM_BUILD) | ||
| + state->second->GrantRequestScheme(kBraveUIScheme); |
There was a problem hiding this comment.
how does this work? content doesn't know anything about kBraveUIScheme
There was a problem hiding this comment.
missed the url_constants.cc chromium_src
There was a problem hiding this comment.
because of chromium_src/content/public/common/url_constants.cc 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uplift request for: #1196
Fix brave/brave-browser#2861
Fix brave/brave-browser#2849
Disclaimer: This is not my PR, I'm uplifting on behalf of @simonhong