-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated labels for Shields v2 panel #12775
Conversation
A Storybook has been deployed to preview UI for the latest push |
I see things that should be changed. Do you mind if I propose changes, that could possibly save you from future extra work on the same stuff? |
89311f1
to
be8367d
Compare
be8367d
to
1414f1a
Compare
A Storybook has been deployed to preview UI for the latest push |
A Storybook has been deployed to preview UI for the latest push |
braveShieldsTrackersAndAdsBlockedStd: 'Trackers & ads blocked (standard)', | ||
braveShieldsTrackersAndAdsBlockedAgg: 'Trackers & ads blocked (aggressive)', | ||
braveShieldsTrackersAndAdsBlockedStd: 'Block trackers & ads', | ||
braveShieldsTrackersAndAdsBlockedAgg: 'Aggressively block trackers & ads blocked', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
braveShieldsTrackersAndAdsBlockedAgg: 'Aggressively block trackers & ads blocked', | |
braveShieldsTrackersAndAdsBlockedAgg: 'Aggressively block trackers & ads', |
braveShieldsCookiesBlocked: 'Cookies blocked', | ||
braveShieldsCookiesBlockedAll: 'All cookies blocked', | ||
braveShieldsCookiesBlockedAll: 'Allow all cookies', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
braveShieldsCookiesBlockedAll: 'Allow all cookies', | |
braveShieldsCookiesBlockedAll: 'Block all cookies', |
1414f1a
to
f55e3b8
Compare
A Storybook has been deployed to preview UI for the latest push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Updated labels for Shields v2 panel
Verified
Confirmed labels match Figma.
Confirmed the following:
|
Resolves brave/brave-browser#21916
Resolves brave/brave-browser#21926
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: