Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update adblock-rust to v0.5.2 #12824

Merged
merged 1 commit into from
Mar 30, 2022
Merged

Update adblock-rust to v0.5.2 #12824

merged 1 commit into from
Mar 30, 2022

Conversation

antonok-edm
Copy link
Collaborator

@antonok-edm antonok-edm commented Mar 30, 2022

Resolves brave/brave-browser#21970

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan

brave/brave-browser#21970 (comment)

@antonok-edm antonok-edm requested a review from atuchin-m March 30, 2022 01:51
@antonok-edm antonok-edm requested a review from a team as a code owner March 30, 2022 01:51
@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Mar 30, 2022
@antonok-edm
Copy link
Collaborator Author

@atuchin-m would you mind adding a test case for QA to the PR description? I'm not familiar with how to reliably test memory usage.

@atuchin-m atuchin-m added this to the 1.39.x - Nightly milestone Mar 30, 2022
@atuchin-m atuchin-m merged commit 06487d9 into master Mar 30, 2022
@atuchin-m atuchin-m deleted the adblock-rust-v0.5.2 branch March 30, 2022 05:01
@atuchin-m
Copy link
Collaborator

@antonok-edm I've added the comment: brave/brave-browser#21970 (comment)

@antonok-edm antonok-edm mentioned this pull request Apr 5, 2022
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce adblock filter memory usage by optimizing unused regex rules
3 participants