-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shields UI follow ups #12885
Shields UI follow ups #12885
Conversation
71e6977
to
6f0a5dc
Compare
A Storybook has been deployed to preview UI for the latest push |
6f0a5dc
to
f9bba9e
Compare
A Storybook has been deployed to preview UI for the latest push |
Verified
Confirmed there's a space in-between the 3-digit count ( |
Verified
Confirmed buttons are |
Verified
Confirmed the ordering of cookies and fingerprint-blocking options now match the Figma spec.
|
Resolves brave/brave-browser#22004
Resolves brave/brave-browser#22012
Resolves brave/brave-browser#22084
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: