Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shields UI follow ups #12885

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Shields UI follow ups #12885

merged 1 commit into from
Apr 5, 2022

Conversation

nullhook
Copy link
Contributor

@nullhook nullhook commented Apr 4, 2022

Resolves brave/brave-browser#22004
Resolves brave/brave-browser#22012
Resolves brave/brave-browser#22084

image

image

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Apr 4, 2022
@nullhook nullhook requested a review from petemill April 4, 2022 21:47
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@nullhook nullhook merged commit 4079264 into master Apr 5, 2022
@nullhook nullhook deleted the shields_ui_follow_ups branch April 5, 2022 05:29
@nullhook nullhook added this to the 1.39.x - Nightly milestone Apr 5, 2022
@nullhook nullhook mentioned this pull request Apr 5, 2022
7 tasks
nullhook added a commit that referenced this pull request Apr 6, 2022
@stephendonner
Copy link
Contributor

stephendonner commented Apr 7, 2022

For brave/brave-browser#22012

Verified PASSED using

Brave 1.39.39 Chromium: 100.0.4896.79 (Official Build) nightly (x86_64)
Revision 8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS macOS Version 11.6.5 (Build 20G527)

Confirmed there's a space in-between the 3-digit count (100+) and the label text of Trackers & ads.

Screen Shot 2022-04-07 at 11 23 44 AM

@stephendonner
Copy link
Contributor

For brave/brave-browser#22004

Verified PASSED using

Brave 1.39.39 Chromium: 100.0.4896.79 (Official Build) nightly (x86_64)
Revision 8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS macOS Version 11.6.5 (Build 20G527)

Confirmed buttons are blurple-colored and are the same, without gradient animations.

Screen Shot 2022-04-07 at 11 28 31 AM

@stephendonner
Copy link
Contributor

For brave/brave-browser#22084

Verified PASSED using

Brave 1.39.39 Chromium: 100.0.4896.79 (Official Build) nightly (x86_64)
Revision 8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS macOS Version 11.6.5 (Build 20G527)

Confirmed the ordering of cookies and fingerprint-blocking options now match the Figma spec.

Trackers & ads Fingerprinting Cookies
Screen Shot 2022-04-07 at 11 35 30 AM Screen Shot 2022-04-07 at 11 35 46 AM Screen Shot 2022-04-07 at 11 35 55 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
4 participants