-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes crash reporting not working on Windows 7. #1292
Conversation
is this also the case for Chrome on win7/8? |
@bridiver, Chrome's crash reporting endpoint (clients2.google.com) accepts TLS 1.0, 1.1, and 1.2, so they don't have a problem. |
chromium_src/third_party/crashpad/crashpad/util/net/http_transport_win.cc
Outdated
Show resolved
Hide resolved
can we fix this in our endpoint? |
I would imagine so, but I think we need @w0ts0n and/or @diracdeltas to chime in. |
in addition to TLS 1.0 used by WinHttp by default. Fixes brave/brave-browser#1188
ca88fc0
to
d0be988
Compare
If i understand the bug correctly (our endpoint only supports tls 1.1 and above, windows 7 by default supports tls 1.0 at maximum) it would be preferable to upgrade windows TLS version rather than downgrade the server TLS version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Gives crashpad an option to use TLS 1.1 and 1.2 on Windows 7 and 8.0
in addition to TLS 1.0 used by WinHttp by default.
Fixes brave/brave-browser#1188
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests
) ongit rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Automatically send crash reports to Brave
in thePrivacy and security
section to ON and click theRelaunch
button that should have appeared next to the toggle;Reviewer Checklist: