Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: exclude ERC-721 tokens from swap #12976

Merged
merged 3 commits into from
Apr 13, 2022

Conversation

josheleonard
Copy link
Contributor

@josheleonard josheleonard commented Apr 11, 2022

Resolves brave/brave-browser#21550

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Unlock wallet - must have ERC-721 tokens (NFTs)
Open swap tab
Click the dropdown for selecting the "from" asset
Notice that none of the wallet's ERC-721 tokens are available to select in the assets list

@josheleonard josheleonard self-assigned this Apr 11, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Apr 11, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Contributor

@Douglashdaniel Douglashdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josheleonard josheleonard added this to the 1.39.x - Nightly milestone Apr 13, 2022
@josheleonard josheleonard merged commit 88c71e6 into master Apr 13, 2022
@josheleonard josheleonard deleted the fix-exclude-erc721-tokens-from-swap branch April 13, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Exclude ERC721 Tokens in Swap
3 participants