Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI and crash fixes for Shields v2 panel (uplift to 1.38.x) #13029

Merged
merged 3 commits into from
Apr 19, 2022
Merged

UI and crash fixes for Shields v2 panel (uplift to 1.38.x) #13029

merged 3 commits into from
Apr 19, 2022

Conversation

nullhook
Copy link
Contributor

@nullhook nullhook commented Apr 14, 2022 •
edited by kjozwiak
Loading

Uplift of #12984 (crash fix)
Uplift of #12994 (ui related fix)

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Apr 14, 2022
@nullhook nullhook requested a review from a team April 14, 2022 22:27
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@nullhook nullhook mentioned this pull request Apr 15, 2022
Closed
@kjozwiak kjozwiak added this to the 1.38.x - Beta milestone Apr 16, 2022
@kjozwiak
Copy link
Member

Restarting as it looks like all the platforms basically failed due to several reasons including failing to checkout the needed source or running into the following issue:


fatal: fetch-pack: invalid index-pack output
[2022-04-18T02:00:05.401Z] 
[2022-04-18T02:00:05.402Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2671)
[2022-04-18T02:00:05.402Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:2096)
[2022-04-18T02:00:05.402Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$500(CliGitAPIImpl.java:84)
[2022-04-18T02:00:05.402Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:618)
[2022-04-18T02:00:05.402Z] 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$2.execute(CliGitAPIImpl.java:847)
[2022-04-18T02:00:05.402Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:158)
[2022-04-18T02:00:05.402Z] 	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:151)
[2022-04-18T02:00:05.402Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:211)
[2022-04-18T02:00:05.402Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:54)
[2022-04-18T02:00:05.402Z] 	at hudson.remoting.Request$2.run(Request.java:376)
[2022-04-18T02:00:05.402Z] 	at hudson.remoting.InterceptingExecutorService.lambda$wrap$0(InterceptingExecutorService.java:78)
[2022-04-18T02:00:05.402Z] 	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
[2022-04-18T02:00:05.402Z] 	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
[2022-04-18T02:00:05.402Z] 	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
[2022-04-18T02:00:05.402Z] 	at java.base/java.lang.Thread.run(Thread.java:829)
[2022-04-18T02:00:05.405Z] 	Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to linux-perm
[2022-04-18T02:00:05.405Z] 		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1784)
[2022-04-18T02:00:05.405Z] 		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:356)
[2022-04-18T02:00:05.405Z] 		at hudson.remoting.Channel.call(Channel.java:1000)
[2022-04-18T02:00:05.405Z] 		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:143)
[2022-04-18T02:00:05.405Z] 		at jdk.internal.reflect.GeneratedMethodAccessor1254.invoke(Unknown Source)
[2022-04-18T02:00:05.405Z] 		at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[2022-04-18T02:00:05.405Z] 		at java.base/java.lang.reflect.Method.invoke(Method.java:566)
[2022-04-18T02:00:05.405Z] 		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:129)
[2022-04-18T02:00:05.405Z] 		at com.sun.proxy.$Proxy109.execute(Unknown Source)
[2022-04-18T02:00:05.405Z] 		at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1216)
[2022-04-18T02:00:05.405Z] 		at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1294)
[2022-04-18T02:00:05.405Z] 		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:129)
[2022-04-18T02:00:05.405Z] 		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:97)
[2022-04-18T02:00:05.405Z] 		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:84)
[2022-04-18T02:00:05.405Z] 		at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)
[2022-04-18T02:00:05.405Z] 		at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
[2022-04-18T02:00:05.405Z] 		... 4 more
[2022-04-18T02:00:05.282Z] ERROR: Timeout after 10 minutes
Error cloning remote repo 'origin'

taher and others added 3 commits April 18, 2022 19:22
Favicon and color fixes for Shields v2
e79eeb5
Cleanup shields v2 inactive state
3c39849
@simonhong
Fixed shields v2 crash with multiple windows
5bec1e8 
fix brave/brave-browser#22224

ShieldsPanelDataHandler should keep observed data controller
instead of getting data controller from active web contents of current
active window because active window could be different on it's created
or destroyed.
Crash happened because ShieldsPanelDataHandler tried to remove itself
from wrong data controller due to above reason.
@nullhook nullhook force-pushed the shields_bugs_1.38.x branch from 8a1423b to 5bec1e8 Compare April 19, 2022 02:23
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@kjozwiak
Copy link
Member

Remaining failures are due to several CookieStoreTest tests failing which is a known issue as per brave/brave-browser#22387 and doesn't block uplift.

kjozwiak
kjozwiak approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.38.x approved 👍 QA has verified the PR on Nightly as per #12984 (comment) & #12994 (comment).

@kjozwiak kjozwiak merged commit a2e3df4 into 1.38.x Apr 19, 2022
@kjozwiak kjozwiak deleted the shields_bugs_1.38.x branch April 19, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@nullhook nullhook

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.38.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@nullhook @brave-builds @kjozwiak @simonhong