Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds update function for pending totals #1305

Merged
merged 1 commit into from
Jan 11, 2019
Merged

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jan 11, 2019

Resolves brave/brave-browser#2890

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  • enable rewards
  • in current window open panel
  • open new window with rewards settings page
  • open new window with unverified site
  • tip that site
  • make sure that panel and settings page display the amount

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@NejcZdovc NejcZdovc force-pushed the pending-contribution branch 2 times, most recently from 384afe6 to f73c643 Compare January 11, 2019 21:06
@NejcZdovc NejcZdovc force-pushed the pending-contribution branch from f73c643 to 84ba860 Compare January 11, 2019 21:06
@NejcZdovc NejcZdovc merged commit be71706 into master Jan 11, 2019
@NejcZdovc NejcZdovc deleted the pending-contribution branch January 11, 2019 21:13
NejcZdovc added a commit that referenced this pull request Jan 11, 2019
Adds update function for pending totals
NejcZdovc added a commit that referenced this pull request Jan 11, 2019
Adds update function for pending totals
@bbondy bbondy added this to the 0.61.x - Nightly milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pending contributions not updated
3 participants