add force paste option to context menu #13178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pes10k
approved these changes
Apr 26, 2022
iefremov
reviewed
May 20, 2022
iefremov
reviewed
May 20, 2022
chromium_src/chrome/browser/renderer_context_menu/render_view_context_menu.cc
Outdated
Show resolved
Hide resolved
iefremov
reviewed
May 20, 2022
| // only enable if there is plain text data to paste - this is what | ||
| // IsPasteAndMatchStyleEnabled checks internally, but IsPasteEnabled | ||
| // allows non text types | ||
| return IsPasteAndMatchStyleEnabled(); |
There was a problem hiding this comment.
it seems we don't actually have tests for this class, but they could be useful
There was a problem hiding this comment.
yes, I've been waiting to merge this because I need to add tests
There was a problem hiding this comment.
seems there are no upstream paste tests so I'm going to leave this for now and maybe do a follow-up
iefremov
approved these changes
May 20, 2022
bridiver
force-pushed
the
issues/22567
branch
2 times, most recently
from
5b4f870 to
576a1f5
Compare
|
unrelated test error that didn't happen on previous runs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#22567
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: