Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save Chromium's mac_min_system_version to a file #13376

Closed
wants to merge 2 commits into from

Conversation

mherrmann
Copy link
Collaborator

@mherrmann mherrmann commented May 18, 2022

This file can be uploaded to S3 in a later step. It can then be read during releases, when we upload the version to the update server. There, we mark the version's minimum OS requirements to prevent it from being rolled out to incompatible systems.

Partially resolves brave/brave-browser#22918, which also requires a change to our CD pipelines.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

This file can be uploaded to S3 in a later step. It can then be
read during releases, when we upload the version to the update
server. There, we mark the version's minimum OS requirements to
prevent it from being rolled out to incompatible systems.
@mherrmann mherrmann added CI/skip-android Do not run CI builds for Android CI/skip-linux CI/skip-ios Do not run CI builds for iOS release-notes/exclude QA/No labels May 18, 2022
@mherrmann mherrmann self-assigned this May 18, 2022
@mherrmann mherrmann requested a review from bridiver May 19, 2022 08:58
@mherrmann
Copy link
Collaborator Author

Closing this in favor of a pipeline-only implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't update Brave on macOS if the new version is unsupported
2 participants