Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reopen sync code dialog when switching desktop <=> mobile #13643

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

AlexeyBarabash
Copy link
Contributor

Resolves brave/brave-browser#23262

The behavior which happens in the original issue doesn't leave any traces in console. It acts like click happened not on the View Sync Code link, but somewhere outside of the modal dialog, this line at onPointerdown_(e) {}

This PR forces to re-open the dialog when its type is changed. This introduces flickering, but UI is always responsible.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Please see brave/brave-browser#23262

@AlexeyBarabash AlexeyBarabash added UI feature/sync CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS labels Jun 7, 2022
@AlexeyBarabash AlexeyBarabash self-assigned this Jun 7, 2022
@AlexeyBarabash AlexeyBarabash requested a review from petemill June 7, 2022 10:12
@AlexeyBarabash
Copy link
Contributor Author

@petemill , PTAL

@AlexeyBarabash AlexeyBarabash force-pushed the sync_ui_add_device_freeze branch from 6388dce to 9510994 Compare June 10, 2022 17:56
Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good find. Whilst it would be good to solve within the same dialog, I think closing and opening the dialog is completely acceptable since it's an implementation detail that it happens to be the same dialog. It just as well could have been separate dialogs.

@AlexeyBarabash AlexeyBarabash added this to the 1.41.x - Nightly milestone Jun 15, 2022
@AlexeyBarabash AlexeyBarabash force-pushed the sync_ui_add_device_freeze branch from 9510994 to e6e0c0a Compare June 15, 2022 20:49
@kjozwiak
Copy link
Member

Using the verification that @MadhaviSeelam completed via brave/brave-browser#23262 (comment) as the check on Nightly for uplifting into 1.41.x & 1.40.x as per #13812 & #13813.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS feature/sync UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to copy code words from existing sync chain
3 participants