Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix buy with ramp broken #13753

Merged
merged 1 commit into from
Jun 13, 2022
Merged

Fix buy with ramp broken #13753

merged 1 commit into from
Jun 13, 2022

Conversation

muliswilliam
Copy link
Contributor

Fixes an issue in nightly where asset symbols for selected asset are not prefixed with network name before generating buy url for ramp provider.

Resolves brave/brave-browser#23425

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Screen.Recording.2022-06-13.at.16.56.32.mov

@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Jun 13, 2022
Copy link
Contributor

@Douglashdaniel Douglashdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@muliswilliam muliswilliam merged commit 4220b55 into master Jun 13, 2022
@muliswilliam muliswilliam deleted the fix-buy-with-ramp branch June 13, 2022 17:14
@github-actions github-actions bot added this to the 1.41.x - Nightly milestone Jun 13, 2022
@muliswilliam muliswilliam restored the fix-buy-with-ramp branch June 15, 2022 11:22
brave-builds pushed a commit that referenced this pull request Jun 15, 2022
@muliswilliam muliswilliam changed the title Fix buy with ramp broken on nightly Fix buy with ramp broken Jun 15, 2022
@muliswilliam muliswilliam deleted the fix-buy-with-ramp branch June 15, 2022 11:28
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.41.64 Chromium: 103.0.5060.42 (Official Build) nightly (64-bit)
Revision de0d840bf9439c31bd86bf74f065c31fdf9b208d-refs/branch-heads/5060@{#667}
OS Windows 11 Version 21H2 (Build 22000.739)
  • Verified steps from PR
  • Verified Ramp link is not broken for any network
13753.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buy with ramp broken
4 participants