Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dapps active tab #13780

Merged
merged 3 commits into from
Jun 15, 2022
Merged

Dapps active tab #13780

merged 3 commits into from
Jun 15, 2022

Conversation

SergeyZhukovsky
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky commented Jun 14, 2022

Resolves brave/brave-browser#23460

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

To achieve that you have to have 2 tabs, one tab has to be a DApp. Somehow it has to be done that when a DApp tab in the background, it tries to send some request.

@SergeyZhukovsky SergeyZhukovsky requested review from a team as code owners June 14, 2022 18:05
@SergeyZhukovsky SergeyZhukovsky self-assigned this Jun 14, 2022
Copy link
Member

@bbondy bbondy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but would be good to have a browsertest that checks it.

@SergeyZhukovsky
Copy link
Member Author

lgtm but would be good to have a browsertest that checks it.

Yup, working on that.

Copy link
Collaborator

@StephenHeaps StephenHeaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@SergeyZhukovsky SergeyZhukovsky added this to the 1.41.x - Nightly milestone Jun 15, 2022
@SergeyZhukovsky SergeyZhukovsky merged commit b1ab968 into master Jun 15, 2022
@SergeyZhukovsky SergeyZhukovsky deleted the dapps_active_tab branch June 15, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent from opening Ethereum DApps dialog in inactive tab
3 participants