-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for min visits #1399
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to test "Plan 2":
Enable Rewards via panel on clean profile. Open Rewards and leave open. Open new tab and visit a site for the required amount of time. Go to Rewards tab and continue changing required visit count. Rewards starts to become sluggish and eventually non-responsive. Close the rewards tab and go back to site that was being visited. Browse the current site again for required time (or go to a new site) and open Rewards settings on new tab. Eventually becomes non-responsive again.
Does not replicate on master.
Suspect something is holding/blocking on the activity table.
7547a5c
to
a72978a
Compare
found out that this is because of this one brave/brave-browser#2973, so this PR is blocked until that one is done |
Resolves brave/brave-browser#2110
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests
) ongit rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
plan 1:
plan 2:
Reviewer Checklist: