Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support .zil for UD #14599

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Support .zil for UD #14599

merged 1 commit into from
Aug 17, 2022

Conversation

supermassive
Copy link
Collaborator

@supermassive supermassive commented Aug 12, 2022

Added .zil to supported list of UD tlds.

Resolves brave/brave-browser#24621

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

jim-unstoppable.zil should be resolvable by browser and redirect to ipfs://QmSEj9K6mAj52CFqCzd5Pbt4DgAFocWovwnn2GJpyFjm3p
Also need to update wiki here https://github.com/brave/brave-browser/wiki/Resolve-Methods-for-Unstoppable-Domains

Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@supermassive supermassive merged commit 2c673ae into master Aug 17, 2022
@supermassive supermassive deleted the zil_for_ud branch August 17, 2022 03:23
@github-actions github-actions bot added this to the 1.44.x - Nightly milestone Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support .zil tld for UD
3 participants