Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes unable to clear notification #1474

Merged
merged 1 commit into from
Jan 28, 2019
Merged

Fixes unable to clear notification #1474

merged 1 commit into from
Jan 28, 2019

Conversation

NejcZdovc
Copy link
Contributor

Original PR: #1424

Resolves brave/brave-browser#2883

@NejcZdovc
Merge pull request #1427 from brave/remove-notification-60
4fe2ee5 
Fixes unable to clear notification
@NejcZdovc NejcZdovc added this to the 0.59.x - Release milestone Jan 28, 2019
@NejcZdovc NejcZdovc self-assigned this Jan 28, 2019
srirambv
srirambv approved these changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@srirambv srirambv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 0.59.x approved after deliberating with @bbondy and @rebron . Please update the issue milestone accordingly.

@NejcZdovc NejcZdovc merged commit 9934d57 into 0.59.x Jan 28, 2019
@NejcZdovc NejcZdovc deleted the remove-notification-59 branch January 28, 2019 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srirambv srirambv srirambv approved these changes

@bbondy bbondy Awaiting requested review from bbondy

@kjozwiak kjozwiak Awaiting requested review from kjozwiak

@bsclifton bsclifton Awaiting requested review from bsclifton

@rebron rebron Awaiting requested review from rebron

Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards
Projects
None yet
Milestone
0.59.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@NejcZdovc @srirambv