Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide safe browsing option #14875

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Hide safe browsing option #14875

merged 2 commits into from
Aug 30, 2022

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented Aug 29, 2022

Resolves brave/brave-browser#25047

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@deeppandya deeppandya added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Aug 29, 2022
@deeppandya deeppandya added this to the 1.45.x - Nightly milestone Aug 29, 2022
@deeppandya deeppandya self-assigned this Aug 29, 2022
@fmarier
Copy link
Member

fmarier commented Aug 29, 2022

Security review not needed since we are already aware that Safe Browsing is not enabled on Android (this PR doesn't change that) and there is an issue for enabling it: brave/brave-browser#8705

Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@deeppandya deeppandya merged commit d2d6b59 into master Aug 30, 2022
@deeppandya deeppandya deleted the hide_safe_browsing_option branch August 30, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide non-working Safe Browsing setting on Android
3 participants