Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes weights in normalize process #1510

Merged
merged 1 commit into from
Jan 30, 2019
Merged

Fixes weights in normalize process #1510

merged 1 commit into from
Jan 30, 2019

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jan 30, 2019 •
edited
Loading

Resolves brave/brave-browser#3163

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  • clean profile
  • enable rewards
  • visit one site
  • make sure that you see it in ac table
  • open publisher db
  • make sure that weight in activity_info table is 100

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@NejcZdovc NejcZdovc added this to the 0.62.x - Nightly milestone Jan 30, 2019
@NejcZdovc NejcZdovc self-assigned this Jan 30, 2019
NejcZdovc
NejcZdovc commented Jan 30, 2019
View reviewed changes
vendor/bat-native-ledger/src/bat_publishers.cc
totalPercents += percents[percents.size() - 1];
weights.push_back((double)list[i].score / (double)list.size() * 100.0);
totalPercents += roundNumber;
weights.push_back(floatNumber);
Copy link
Contributor Author

@NejcZdovc NejcZdovc Jan 30, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one is where the bug is. before it was divided by list.size(), where after is divided with totalScores as it was in JS

mrose17
mrose17 approved these changes Jan 30, 2019
View reviewed changes
Copy link
Member

@mrose17 mrose17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NejcZdovc NejcZdovc merged commit 7b971ce into master Jan 30, 2019
@NejcZdovc NejcZdovc deleted the weight-fix branch January 30, 2019 15:52
NejcZdovc added a commit that referenced this pull request Jan 30, 2019
@NejcZdovc
Merge pull request #1510 from brave/weight-fix
fe9bc80 
Fixes weights in normalize process
@NejcZdovc NejcZdovc mentioned this pull request Jan 30, 2019
Merged
NejcZdovc added a commit that referenced this pull request Jan 30, 2019
@NejcZdovc
Merge pull request #1510 from brave/weight-fix
2766a12 
Fixes weights in normalize process
This was referenced Jan 30, 2019
Merged
Merged
@LaurenWags LaurenWags mentioned this pull request Jan 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrose17 mrose17 mrose17 approved these changes

@SergeyZhukovsky SergeyZhukovsky Awaiting requested review from SergeyZhukovsky

Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards
Projects
None yet
Milestone
0.62.x - Release
Development

Successfully merging this pull request may close these issues.

Weight is not implemented correctly
2 participants
@NejcZdovc @mrose17