Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle expired state for subscriptions #15463

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Handle expired state for subscriptions #15463

merged 1 commit into from
Oct 17, 2022

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Oct 14, 2022

Resolves brave/brave-browser#22972

  • Handle expired state for subscriptions
  • Moved response json parsing to separate file

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Steps from issue

@spylogsster
Copy link
Contributor Author

@stephendonner I corrected state inside the service, now we have another dialog for payment errors, filed another issue about it brave/brave-browser#26024

@spylogsster spylogsster force-pushed the brave-22972 branch 6 times, most recently from 8ff6bdf to b5043f6 Compare October 15, 2022 12:13
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@spylogsster spylogsster merged commit d7e0494 into master Oct 17, 2022
@spylogsster spylogsster deleted the brave-22972 branch October 17, 2022 06:34
@github-actions github-actions bot added this to the 1.46.x - Nightly milestone Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect error dialog used when credentials fail
2 participants