Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update adblock-rust to v0.5.8 #15578

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Update adblock-rust to v0.5.8 #15578

merged 1 commit into from
Oct 21, 2022

Conversation

antonok-edm
Copy link
Collaborator

Resolves brave/brave-browser#26075

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See Steps to Reproduce from brave/brave-browser#26075. The browser should not crash.

@antonok-edm antonok-edm requested a review from a team as a code owner October 20, 2022 21:32
@antonok-edm antonok-edm self-assigned this Oct 20, 2022
@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Oct 20, 2022
@antonok-edm antonok-edm merged commit effc27c into master Oct 21, 2022
@antonok-edm antonok-edm deleted the adblock-rust-v0.5.8 branch October 21, 2022 00:56
@github-actions github-actions bot added this to the 1.47.x - Nightly milestone Oct 21, 2022
brave-builds pushed a commit that referenced this pull request Oct 21, 2022
@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.47.18 Chromium: 107.0.5304.62 (Official Build) nightly (64-bit)
-- | --
Revision | 1eec40d3a5764881c92085aaee66d25075c159aa-refs/branch-heads/5304@{#942}
OS | Windows 11 Version 22H2 (Build 22621.675)

Using the STR/Cases outlined via brave/brave-browser#26075 (comment), reproduced the issue using 1.47.8 Chromium: 107.0.5304.36. Once reproduced, verified that the crash wasn't occurring with 1.47.18 Chromium: 107.0.5304.62 as per the following:

Example Example
fixed1 fixed2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browser crash on https://d3ward.github.io/toolz/adblock with enabled Ru Adlist
3 participants