Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add referrer-spoofing exceptions for Google Accounts (fixes brave/bra… #1587

Merged
merged 1 commit into from
Feb 6, 2019
Merged

Add referrer-spoofing exceptions for Google Accounts (fixes brave/bra… #1587

merged 1 commit into from
Feb 6, 2019

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Feb 6, 2019

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@fmarier
Add referrer-spoofing exceptions for Google Accounts (fixes brave/bra…
3e112ea 
…ve-browser#1356)

Logging into Google Accounts with the Google Prompt 2FA mechanism
doesn't work unless we send the correct referrer as part of the
long-polling XHR to content.googleapis.com.
@fmarier fmarier added this to the 0.60.x - Beta milestone Feb 6, 2019
@fmarier fmarier self-assigned this Feb 6, 2019
@fmarier
Copy link
Member Author

fmarier commented Feb 6, 2019

This PR is the same as #1543 and #1551. It fixes a referrer issue with Google Prompt 2FA (brave/brave-browser#1356).

@fmarier fmarier requested a review from bbondy February 6, 2019 02:00
@fmarier
Copy link
Member Author

fmarier commented Feb 6, 2019

It's pretty low-risk, comes with a unit test and fixes a login problem for anybody using Google Prompt as their 2FA mechanism. I have tested it on a 0.60.x build, both before and after this fix.

@bbondy
Copy link
Member

bbondy commented Feb 6, 2019

For uplift requests you can just put in comment 0 next time something like:

Fix
Uplift for

To save time.

@fmarier fmarier merged commit fe27d87 into brave:0.60.x Feb 6, 2019
@fmarier fmarier deleted the issue1356-0.60.x branch February 6, 2019 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbondy bbondy bbondy approved these changes

Assignees

@fmarier fmarier

Labels
None yet
Projects
None yet
Milestone
0.60.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@fmarier @bbondy