Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wknapik generic testing 02 #15971

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

wknapik generic testing 02 #15971

wants to merge 2 commits into from
+2 −0

Conversation

wknapik
Copy link
Collaborator

@wknapik wknapik commented Nov 16, 2022 •
edited
Loading

PLEASE DO NOT REVIEW, THIS IS JUST A TEST PR

Resolves https://github.com/wknapik/test/issues/231

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@wknapik wknapik requested a review from a team as a code owner November 16, 2022 14:54
@wknapik wknapik self-assigned this Nov 16, 2022
brave-builds added a commit that referenced this pull request Dec 6, 2022
@brave-builds
Uplift of #15971 (squashed) to beta
e9094f8
@brave-builds brave-builds mentioned this pull request Dec 6, 2022
Closed
7 tasks
@wknapik wknapik added the CI/skip Do not run CI builds (except noplatform) label Jan 26, 2023
@wknapik wknapik force-pushed the wknapik-generic-testing02 branch 2 times, most recently from 000dacc to 75289b8 Compare January 26, 2023 23:31
@wknapik wknapik removed the CI/skip Do not run CI builds (except noplatform) label Jan 27, 2023
@wknapik wknapik force-pushed the wknapik-generic-testing02 branch from 75289b8 to de6c008 Compare January 27, 2023 05:15
@wknapik wknapik changed the base branch from 1.46.x to master January 27, 2023 05:17
@wknapik wknapik requested a review from a team as a code owner January 27, 2023 05:17
@wknapik wknapik force-pushed the wknapik-generic-testing02 branch from 1189c3a to ecf23b1 Compare May 22, 2023 14:37
@wknapik wknapik added CI/run-network-audit Run network-audit CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 CI/skip-linux-arm64 labels May 22, 2023
@wknapik wknapik force-pushed the wknapik-generic-testing02 branch 2 times, most recently from 0885ba7 to 9a35a17 Compare May 23, 2023 12:29
@kjozwiak kjozwiak removed the request for review from a team May 25, 2023 03:27
@wknapik wknapik added CI/skip-windows-x86 CI/skip-windows-x64 Do not run CI builds for Windows x64 and removed CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) labels May 25, 2023
@wknapik wknapik force-pushed the wknapik-generic-testing02 branch from 9a35a17 to a61a6a0 Compare May 25, 2023 11:39
@wknapik wknapik removed the CI/skip-ios Do not run CI builds for iOS label May 25, 2023
@wknapik wknapik removed CI/run-windows-arm64 Run CI builds for Windows arm64 CI/run-windows-x86 Run CI builds for Windows x86 CI/run-macos-x64 Run CI builds for macOS x64 chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch labels Nov 5, 2024
@wknapik wknapik force-pushed the wknapik-generic-testing02 branch from 0ce2a12 to afaa17b Compare November 5, 2024 15:31
@wknapik wknapik force-pushed the wknapik-generic-testing02 branch from 7e675c4 to 7373040 Compare November 13, 2024 13:31
@wknapik wknapik requested review from a team and simonhong as code owners November 13, 2024 13:31
@wknapik wknapik added the CI/skip-windows-x64 Do not run CI builds for Windows x64 label Nov 13, 2024
@wknapik wknapik force-pushed the wknapik-generic-testing02 branch from 3c503bd to 84e29d4 Compare November 13, 2024 22:14
@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Nov 13, 2024
@wknapik wknapik added chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch CI/skip Do not run CI builds (except noplatform) and removed chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/skip-windows-x64 Do not run CI builds for Windows x64 labels Nov 14, 2024
@wknapik wknapik force-pushed the wknapik-generic-testing02 branch from b733539 to 139d0d0 Compare November 14, 2024 21:23
@github-actions github-actions bot added CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch labels Nov 14, 2024
@wknapik wknapik force-pushed the wknapik-generic-testing02 branch from 139d0d0 to 5619750 Compare November 14, 2024 21:24
@github-actions github-actions bot removed the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Nov 14, 2024
@wknapik wknapik added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 and removed CI/skip Do not run CI builds (except noplatform) CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) labels Nov 18, 2024
@wknapik wknapik force-pushed the wknapik-generic-testing02 branch from 383b707 to b6afb67 Compare November 18, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton Awaiting requested review from bsclifton bsclifton is a code owner

@simonhong simonhong Awaiting requested review from simonhong

At least 1 approving review is required to merge this pull request.

Assignees

@wknapik wknapik

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wknapik