Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gateway.PublicGateways to the IPFS localnode config #16129

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Conversation

cypt4
Copy link
Collaborator

@cypt4 cypt4 commented Nov 29, 2022

Resolves brave/brave-browser#22927
See ipfs/kubo#9328 (review)

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Clear browser cache, enable local node, update kubo to 0.17 with --use-dev-goupdater-url flag
  2. Load ipns://en.wikipedia-on-ipfs.org
  3. Check that en-wikipedia--on--ipfs-org.ipns.localhost is loaded.
  4. Also check that local node is working correctly on kubo < 0.17.0

Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: 30a2ad4
reason: unsigned
Please follow the handbook to configure commit signing
cc: @cypt4

@cypt4
Copy link
Collaborator Author

cypt4 commented Dec 11, 2022

/build macos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify IPFS DNSLink behaviors for local and public gateway
2 participants