Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated sidebar's config button target url #16325

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Dec 12, 2022

fix brave/brave-browser#27298

Changed from brave://settings/?search=Show%20Sidebar to brave://settings/?search=Sidebar

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See the linked issue

@simonhong simonhong requested a review from rebron December 12, 2022 01:34
@simonhong simonhong self-assigned this Dec 12, 2022
@simonhong simonhong marked this pull request as ready for review December 12, 2022 23:40
@simonhong simonhong force-pushed the update_sidebar_config_url_from_sidebar branch from c517f17 to 7b6d727 Compare December 12, 2022 23:40
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming that the old string is still used somewhere and we can't just remove it

@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: 7b6d7278e0a5b56a6ad3be67c14b4c789c9ede20
reason: unsigned
Please follow the handbook to configure commit signing
cc: @simonhong

@simonhong
Copy link
Member Author

LGTM, assuming that the old string is still used somewhere and we can't just remove it

Yes, it's still used from several places.

fix brave/brave-browser#27298

Changed from brave://settings/?search=Show%20Sidebar to
brave://settings/?search=Sidebar
@simonhong simonhong force-pushed the update_sidebar_config_url_from_sidebar branch from 7b6d727 to 8eea9c8 Compare December 13, 2022 03:21
@simonhong simonhong merged commit e1ff5d2 into master Dec 13, 2022
@simonhong simonhong deleted the update_sidebar_config_url_from_sidebar branch December 13, 2022 06:39
@github-actions github-actions bot added this to the 1.48.x - Nightly milestone Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update sidebar config button url
2 participants