Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CI to pass with node v18+ #16344

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Conversation

petemill
Copy link
Member

Perform same crypto.createHash node v18 workaround that we have in the build webpack v4 config, in the Storybook webpack v4 config

Resolves brave/brave-browser#27327

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

…e build webpack v4 config, in the Storybook webpack v4 config
@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: 98d7166
reason: unsigned
Please follow the handbook to configure commit signing
cc: @petemill

@mihaiplesa mihaiplesa merged commit fee84e2 into master Dec 13, 2022
@mihaiplesa mihaiplesa deleted the node-18-webpack-storybook branch December 13, 2022 08:03
@github-actions github-actions bot added this to the 1.48.x - Nightly milestone Dec 13, 2022
brave-builds pushed a commit that referenced this pull request Dec 13, 2022
brave-builds pushed a commit that referenced this pull request Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support building Storybook with node v18
3 participants