Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync ignore metadata changes #1636

Merged
merged 2 commits into from
Feb 15, 2019
Merged

Conversation

AlexeyBarabash
Copy link
Contributor

Fixes brave/brave-browser#3281 .
Do not send update record if metadata is changed. We are not interested in any metadata changes. Chromium changes bookmark metadata if url had been visited and this triggered unneeded send of UPDATE record.

Submitter Checklist:

  • Submitted a #3281 for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Taken from brave/brave-browser#3281 .

  1. Create chain brave-core1 <=> brave-core2
  2. On brave-core1 visit duckduckgo.com, bookmark it and close the tab
  3. Wait for this bookmark appear on brave-core2
  4. On brave-core1 open chrome://inspect/#extensions => inspect link under Brave Sync => console
  5. On brave-core1 open duckduckgo.com from bookmarks
  6. No send record in console with "action":1 in ~ 1 minute

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@AlexeyBarabash AlexeyBarabash force-pushed the sync_ignore_metadata_changes branch from cbde33e to acc0797 Compare February 14, 2019 11:25
@AlexeyBarabash AlexeyBarabash force-pushed the sync_ignore_metadata_changes branch from acc0797 to 2988f0f Compare February 14, 2019 16:29
@AlexeyBarabash AlexeyBarabash merged commit f98b8ef into master Feb 15, 2019
AlexeyBarabash added a commit that referenced this pull request Feb 15, 2019
AlexeyBarabash added a commit that referenced this pull request Feb 15, 2019
@bsclifton bsclifton deleted the sync_ignore_metadata_changes branch February 19, 2019 21:32
AlexeyBarabash added a commit that referenced this pull request Feb 20, 2019
AlexeyBarabash added a commit that referenced this pull request Feb 21, 2019
…es_0.61.x

Merge pull request #1636 from brave/sync_ignore_metadata_changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Sync: don't send record to sync cloud if bookmark metadata has changed
2 participants