Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P3a onboarding change android #16382

Merged
merged 3 commits into from
Dec 15, 2022
Merged

Conversation

deeppandya
Copy link
Contributor

Resolves brave/brave-browser#27387
Resolves brave/brave-browser#27279

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@deeppandya deeppandya added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Dec 15, 2022
@deeppandya deeppandya added this to the 1.48.x - Nightly milestone Dec 15, 2022
@deeppandya deeppandya self-assigned this Dec 15, 2022
@@ -45,7 +45,8 @@
public class WelcomeOnboardingActivity extends FirstRunActivityBase {
// mInitializeViewsDone and mInvokePostWorkAtInitializeViews are accessed
// from the same thread, so no need to use extra locks
private static final String P3A_URL = "https://brave.com/privacy/browser/#how-we-improve-brave";
private static final String P3A_URL =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In ticket it's mentioned URL : https://support.brave.com/hc/en-us/articles/9140465918093-What-is-P3A-in-Brave-
Here missing one dash(-) at the end.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sujitacharya2005 it works well without - at the end.

@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: 7339bec
reason: unsigned
Please follow the handbook to configure commit signing
cc: @deeppandya

Copy link
Contributor

@tapanmodh tapanmodh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deeppandya deeppandya merged commit 90ed7df into master Dec 15, 2022
@deeppandya deeppandya deleted the p3a_onboarding_change_android branch December 15, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
3 participants