-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
P3a onboarding change android #16382
Conversation
@@ -45,7 +45,8 @@ | |||
public class WelcomeOnboardingActivity extends FirstRunActivityBase { | |||
// mInitializeViewsDone and mInvokePostWorkAtInitializeViews are accessed | |||
// from the same thread, so no need to use extra locks | |||
private static final String P3A_URL = "https://brave.com/privacy/browser/#how-we-improve-brave"; | |||
private static final String P3A_URL = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In ticket it's mentioned URL : https://support.brave.com/hc/en-us/articles/9140465918093-What-is-P3A-in-Brave-
Here missing one dash(-) at the end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sujitacharya2005 it works well without -
at the end.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves brave/brave-browser#27387
Resolves brave/brave-browser#27279
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: