Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes AC for 1min setting #1658

Merged
merged 1 commit into from
Feb 14, 2019
Merged

Fixes AC for 1min setting #1658

merged 1 commit into from
Feb 14, 2019

Conversation

NejcZdovc
Copy link
Contributor

Resolves brave/brave-browser#3320

Original PR: #1507

@NejcZdovc NejcZdovc added this to the 0.60.x - Beta milestone Feb 13, 2019
@NejcZdovc NejcZdovc self-assigned this Feb 13, 2019
@bsclifton bsclifton self-requested a review February 13, 2019 21:59
@bsclifton
Copy link
Member

Checked out locally - tests all pass 🎉

However, when running (even with a fresh profile), I'm not able to get the entries shown in A/C table. After setting to 1 minute and restarting, I went to cnn.com and stayed on the page for 3 minutes (not switching tabs or anything). I also tried opening a few story links and staying on there too, no luck

@bsclifton
Copy link
Member

Tried a few others sites - same experience. Built from source using 0.60.x brave-browser branch with brave-core branch set to score-fix-test-60 in package.json. I did a npm run sync -- --all && npm run build and then had a fresh profile

bsclifton
bsclifton requested changes Feb 13, 2019
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@bbondy bbondy removed their request for review February 14, 2019 04:10
bsclifton
bsclifton approved these changes Feb 14, 2019
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted src/out/Debug and ran npm run init on 0.60.x brave-browser. Did a fresh build and this is now working 😄

I did notice it seems to be a bit picky; you can't blur the page you're viewing or else the timer resets. This seems to be expected behavior though! 😄

@NejcZdovc NejcZdovc merged commit da566c3 into 0.60.x Feb 14, 2019
@bsclifton bsclifton deleted the score-fix-test-60 branch February 14, 2019 19:47
This was referenced Sep 1, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

@kjozwiak kjozwiak Awaiting requested review from kjozwiak

@rebron rebron Awaiting requested review from rebron

@srirambv srirambv Awaiting requested review from srirambv

Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards
Projects
None yet
Milestone
0.60.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@NejcZdovc @bsclifton