Fix white flash on NTP #1680
Merged
Fix white flash on NTP #1680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After talking with @petemill, a more appropriate solve for this in the long run is to investigate setting the image itself as a background on the body. The grey background will help ease the initial load, but the jump issue will likely be fixed with that approach in some capacity. |
This was referenced Feb 15, 2019
rossmoody
added a commit
that referenced
this pull request
Feb 15, 2019
Merge pull request #1680 from brave/new-tab-bg
rossmoody
added a commit
that referenced
this pull request
Feb 23, 2019
Merge pull request #1680 from brave/new-tab-bg (uplift to 0.61.x)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: brave/brave-browser#2568
Fixes: brave/brave-browser#3362
From all the builds and different ways of surfacing the
bodybackground-color I tried, this is the only way I could get it to persist when opening a new webpage from NTP (and not show the white bar at the bottom). If theCSSis designated anywhere else thebackground colorwill load correctly but it won't fill the whole viewport when navigating away from NTP and the white strip surfaces at the bottom.This helps with the stark white bar being quite so apparent but a real fix for that problem is likely much more difficult and larger than just the scope of
NTP. The background color helps that white flash before the images load as well.Video of the refresh: https://d.pr/i/JtzC4p