Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uplift of #16643 (squashed) to beta (uplift to 1.48.x) #16825

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Uplift of #16643 (squashed) to beta (uplift to 1.48.x) #16825

merged 1 commit into from
Jan 25, 2023

Conversation

Pavneet-Sing
Copy link

@Pavneet-Sing Pavneet-Sing commented Jan 24, 2023 •
edited by kjozwiak
Loading

Uplift of #16643
Resolves brave/brave-browser#27777

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@Pavneet-Sing Pavneet-Sing added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jan 24, 2023
@Pavneet-Sing Pavneet-Sing requested a review from a team as a code owner January 24, 2023 15:00
@Pavneet-Sing Pavneet-Sing self-assigned this Jan 24, 2023
@Pavneet-Sing Pavneet-Sing added this to the 1.48.x - Beta milestone Jan 24, 2023
@Pavneet-Sing Pavneet-Sing force-pushed the pr16643_feat-show-nft-section-on-portfolio_1.48.x branch from 5fd611a to 5d70ce7 Compare January 24, 2023 15:55
kjozwiak
kjozwiak approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.48.x approved 👍 QA has verified the PR on Nightly as per #16643 (comment).

@kjozwiak kjozwiak merged commit 62785d8 into 1.48.x Jan 25, 2023
@kjozwiak kjozwiak deleted the pr16643_feat-show-nft-section-on-portfolio_1.48.x branch January 25, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@Pavneet-Sing Pavneet-Sing

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.48.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@Pavneet-Sing @kjozwiak