Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update adaptive icons for Android #16875

Merged
merged 2 commits into from
Jan 26, 2023
Merged

Conversation

simoarpe
Copy link
Collaborator

@simoarpe simoarpe commented Jan 26, 2023

Resolves brave/brave-browser#27937

Updates Brave adaptive icons for Android.
New icons will appear slightly bigger.

Screenshot 2023-01-26 at 4 12 11 PM

Update_adaptive_icons_for_Android_by_simoarpe_·_Pull_Request__16875_·_brave_brave-core

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Launch Brave
  2. During onboarding, tap on Set as default browser
  3. Tap through to see and set the system-default browser
  4. Compare Brave's icon to the other browsers'

@simoarpe simoarpe self-assigned this Jan 26, 2023
@simoarpe simoarpe added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jan 26, 2023
Copy link
Collaborator

@aguscruiz aguscruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you so much 👏

Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link
Contributor

@stephendonner stephendonner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a code reviewer (even for SVG files) but I play one on TV

r+; looks great, thanks!

@simoarpe simoarpe merged commit a474452 into master Jan 26, 2023
@simoarpe simoarpe deleted the simone/update-adaptive-icons branch January 26, 2023 15:49
@github-actions github-actions bot added this to the 1.49.x - Nightly milestone Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brave default-browser icons are incorrectly sized in Android's Browser app picker
4 participants