Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): Allow exit from wallet #16877

Merged
merged 1 commit into from
Jan 27, 2023
Merged

fix(wallet): Allow exit from wallet #16877

merged 1 commit into from
Jan 27, 2023

Conversation

Pavneet-Sing
Copy link

Resolves brave/brave-browser#27787

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Allow exit via back press on wallet, wallet-login, wallet-welcome on Android 13+
  2. Should work without any issue on APIs below Android 13
fix-back-action-api-33.webm

@Pavneet-Sing Pavneet-Sing added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jan 26, 2023
@Pavneet-Sing Pavneet-Sing self-assigned this Jan 26, 2023
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++. I added @tapanmodh and @deeppandya as they were going to look at it.

Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* This should only be used to resolve Android 13+ back press issue
* {@link https://github.com/brave/brave-browser/issues/27787}.
*/
public final class Api33AndPlusBackPressHelper {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks amazing. Thank you @Pavneet-Sing for adding it.

@Pavneet-Sing Pavneet-Sing merged commit 3becbda into master Jan 27, 2023
@Pavneet-Sing Pavneet-Sing deleted the fix-back-press branch January 27, 2023 06:42
@github-actions github-actions bot added this to the 1.49.x - Nightly milestone Jan 27, 2023
Pavneet-Sing pushed a commit that referenced this pull request Jan 30, 2023
Pavneet-Sing pushed a commit that referenced this pull request Jan 30, 2023
@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 running 1.49.75 x64 Nightly build

  • Verified able to navigate back from Wallet to tabs
  • Verified able to navigate back to different screens within the wallet
16877.mp4

kjozwiak pushed a commit that referenced this pull request Jan 31, 2023
kjozwiak pushed a commit that referenced this pull request Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to go back from wallet view using back button [Android 13]
4 participants