-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(wallet): Allow exit from wallet #16877
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++. I added @tapanmodh and @deeppandya as they were going to look at it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* This should only be used to resolve Android 13+ back press issue | ||
* {@link https://github.com/brave/brave-browser/issues/27787}. | ||
*/ | ||
public final class Api33AndPlusBackPressHelper { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks amazing. Thank you @Pavneet-Sing for adding it.
Verification passed on Oppo Reno 5 running 1.49.75 x64 Nightly build
16877.mp4 |
Uplift of #16877 (squashed) to beta
Uplift of #16877 (squashed) to release
Resolves brave/brave-browser#27787
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
fix-back-action-api-33.webm