Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wallet GPS): wallet services issue from activity (uplift to 1.48.x) #17191

Merged
merged 1 commit into from
Feb 15, 2023
Merged

fix(wallet GPS): wallet services issue from activity (uplift to 1.48.x) #17191

merged 1 commit into from
Feb 15, 2023

Conversation

Pavneet-Sing
Copy link

@Pavneet-Sing Pavneet-Sing commented Feb 14, 2023 •
edited by kjozwiak
Loading

Uplift of #17162
Resolves brave/brave-browser#28452

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@Pavneet-Sing Pavneet-Sing added CI/skip Do not run CI builds (except noplatform) CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Feb 14, 2023
@Pavneet-Sing Pavneet-Sing requested a review from a team as a code owner February 14, 2023 07:30
@Pavneet-Sing Pavneet-Sing self-assigned this Feb 14, 2023
@Pavneet-Sing Pavneet-Sing changed the title Uplift of #17162 (squashed) to release fix(wallet GPS): wallet services issue from activity (uplift to 1.48.x) Feb 14, 2023
kjozwiak
kjozwiak approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.48.x approved 👍 QA has verified the PR on Nightly as per #17162 (comment).

@kjozwiak kjozwiak added this to the 1.48.x - Release #4 milestone Feb 15, 2023
@kjozwiak kjozwiak merged commit 3937b40 into 1.48.x Feb 15, 2023
@kjozwiak kjozwiak deleted the pr17162_fix-portfolio-crash_1.48.x branch February 15, 2023 14:11
@atifnimran

This comment was marked as spam.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@Pavneet-Sing Pavneet-Sing

Labels
CI/skip Do not run CI builds (except noplatform) CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.48.x - Release #5
Development

Successfully merging this pull request may close these issues.
3 participants
@Pavneet-Sing @atifnimran @kjozwiak