-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger user gesture events on browser initiated navigations. #17490
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Verification passed on Brave v1.51.30 on Lenovo TB-8506FS (Android 11.0) Verified searching for
Verified opening a page through omnibox increases user activity score
Verified clicking on a link on a page increases user activity score
Verified ad was shown when threshold was reached
|
Add triggering of user gesture events on browser-initiated navigations because some browser-initiated navigations have HasUserGesture set to false (crbug.com/617904).
Resolves brave/brave-browser#28826
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: