Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use selected account rather than fee_payer as from when adding Solana dApp transactions (uplift to 1.50.x) #17560

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Use selected account rather than fee_payer as from when adding Solana dApp transactions (uplift to 1.50.x) #17560

merged 1 commit into from
Mar 14, 2023

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Mar 10, 2023 •
edited by kjozwiak
Loading

Uplift of #17553
Resolves brave/brave-browser#28955

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner March 10, 2023 17:22
@brave-builds brave-builds self-assigned this Mar 10, 2023
@brave-builds brave-builds added this to the 1.50.x - Beta milestone Mar 10, 2023
@yrliou
Copy link
Member

yrliou commented Mar 13, 2023

macOS only failed at TimePeriodStorageTest.GetSumInCustomPeriod test which is known and unrelated.

kjozwiak
kjozwiak approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.50.x approved 👍 QA has verified the PR on Nightly as per #17553 (comment).

@kjozwiak kjozwiak merged commit 8d93dce into 1.50.x Mar 14, 2023
@kjozwiak kjozwiak deleted the pr17553_solana_sign_and_send_bug_1.50.x branch March 14, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.50.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @yrliou @kjozwiak