Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated label in brave://settings/newTab #17935

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Apr 5, 2023

Resolves brave/brave-browser#29524

Screenshot 2023-04-05 at 8 32 19 PM

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@simonhong simonhong requested a review from stephendonner April 5, 2023 11:38
@simonhong simonhong self-assigned this Apr 5, 2023
Copy link
Contributor

@stephendonner stephendonner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ yes please, and thanks!

@simonhong simonhong merged commit 1eae5d2 into master Apr 5, 2023
@simonhong simonhong deleted the update_settings_label branch April 5, 2023 22:34
@github-actions github-actions bot added this to the 1.52.x - Nightly milestone Apr 5, 2023
@stephendonner
Copy link
Contributor

Verified PASSED using

Brave 1.52.32 Chromium: 112.0.5615.49 (Official Build) nightly (64-bit)
Revision bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS Windows 10 Version 22H2 (Build 19045.2788)

Steps:

  1. installed 1.52.32
  2. launched Brave
  3. opened brave://settings/newTab
  4. checked the label for Customize new tab page
  5. compared to 1.51.84

Confirmed the label now reads Customize new tab page

1.52.32 1.51.84
image image (1)

@rebron @simonhong @kjozwiak we should uplift this, yes?

brave-builds added a commit that referenced this pull request Apr 12, 2023
kjozwiak pushed a commit that referenced this pull request Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update label in brave://settings/newTab
2 participants