Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes a crash on Android8 send tip button click (uplift to 1.51.x) #18019

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Fixes a crash on Android8 send tip button click (uplift to 1.51.x) #18019

merged 1 commit into from
Apr 13, 2023

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Apr 12, 2023 •
edited by kjozwiak
Loading

Uplift of #17955
Resolves brave/brave-browser#29562

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner April 12, 2023 16:02
@brave-builds brave-builds self-assigned this Apr 12, 2023
@brave-builds brave-builds added this to the 1.51.x - Beta milestone Apr 12, 2023
@SergeyZhukovsky SergeyZhukovsky added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x86 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 labels Apr 12, 2023
kjozwiak
kjozwiak approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.51.x approved 👍 QA has verified the PR on Nightly as per #17955 (comment).

@kjozwiak kjozwiak merged commit 3270cfe into 1.51.x Apr 13, 2023
@kjozwiak kjozwiak deleted the pr17955_android8_sendtip_crash_1.51.x branch April 13, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Milestone
1.51.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @SergeyZhukovsky