Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IPFS gateway Android setting #18042

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Fix IPFS gateway Android setting #18042

merged 1 commit into from
Apr 20, 2023

Conversation

cypt4
Copy link
Collaborator

@cypt4 cypt4 commented Apr 13, 2023 •
edited
Loading

Resolves brave/brave-browser#29647

ENABLE_IPFS flag was not taken into respect

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Check whether IPFS Gateway setting is enabled by default on Android
  2. Switch IPFS Gateway setting on Android
  3. Re-enter settings page
  4. Make sure setting has proper state
  5. Make sure ipfs:// urls are loading when setting is enabled and are not loading when it is disabled

@cypt4 cypt4 force-pushed the brave_29647 branch 2 times, most recently from d0ff6d6 to 8a6ca48 Compare April 13, 2023 11:33
AlexeyBarabash
AlexeyBarabash approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@AlexeyBarabash
Copy link
Contributor

I added the reviewers suggested by GitHub

wchen342
wchen342 approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@wchen342 wchen342 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

SergeyZhukovsky
SergeyZhukovsky approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@cypt4 cypt4 force-pushed the brave_29647 branch 2 times, most recently from 69943d3 to 93e21da Compare April 14, 2023 19:58
@cypt4 cypt4 merged commit 5be6f7e into master Apr 20, 2023
@cypt4 cypt4 deleted the brave_29647 branch April 20, 2023 08:06
@github-actions github-actions bot added this to the 1.52.x - Nightly milestone Apr 20, 2023
deeppandya pushed a commit that referenced this pull request May 11, 2023
@cypt4 @deeppandya
Fix IPFS gateway Android setting (#18042)
e081f73 
Resolves brave/brave-browser#29647
@deeppandya deeppandya mentioned this pull request May 11, 2023
Merged
7 tasks
kjozwiak pushed a commit that referenced this pull request May 15, 2023
@deeppandya @cypt4
Fix IPFS gateway Android setting (#18042) (Uplift to 1.51.x) (#18450)
dbe5115 
Fix IPFS gateway Android setting (#18042)

Resolves brave/brave-browser#29647

Co-authored-by: cypt4 <106654560+cypt4@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexeyBarabash AlexeyBarabash AlexeyBarabash approved these changes

@SergeyZhukovsky SergeyZhukovsky SergeyZhukovsky approved these changes

@wchen342 wchen342 wchen342 approved these changes

@fmarier fmarier fmarier approved these changes

Assignees

@cypt4 cypt4

Labels
None yet
Projects
None yet
Milestone
1.52.x - Release
Development

Successfully merging this pull request may close these issues.

IPFS settings doesn't match feature state
5 participants
@cypt4 @AlexeyBarabash @fmarier @wchen342 @SergeyZhukovsky