Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Brave Ads #18076

Merged
merged 11 commits into from
Apr 15, 2023
Merged

Cleanup Brave Ads #18076

merged 11 commits into from
Apr 15, 2023

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Apr 14, 2023

Resolves brave/brave-browser#29732

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@tmancey tmancey self-assigned this Apr 14, 2023
@tmancey tmancey requested a review from a team as a code owner April 14, 2023 15:49
@tmancey tmancey force-pushed the issues/29732 branch 3 times, most recently from b09a917 to 87c913b Compare April 14, 2023 16:32
@tmancey tmancey force-pushed the issues/29732 branch 2 times, most recently from e31672d to 9cc26c1 Compare April 14, 2023 20:32
@tmancey tmancey force-pushed the issues/29732 branch 2 times, most recently from 86c9300 to 3834382 Compare April 15, 2023 00:09
@tmancey tmancey enabled auto-merge April 15, 2023 06:33
@tmancey tmancey force-pushed the issues/29732 branch 6 times, most recently from 9e94191 to c8d4391 Compare April 15, 2023 09:07
@wknapik wknapik disabled auto-merge April 15, 2023 18:42
@wknapik wknapik merged commit 071e876 into master Apr 15, 2023
@wknapik wknapik deleted the issues/29732 branch April 15, 2023 18:43
@github-actions github-actions bot added this to the 1.52.x - Nightly milestone Apr 15, 2023
@wknapik
Copy link
Collaborator

wknapik commented Apr 15, 2023

Force-merged on request https://bravesoftware.slack.com/archives/C7VLGSR55/p1681581550522949

@aseren aseren mentioned this pull request May 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aseren aseren aseren approved these changes

Assignees

@tmancey tmancey

Labels
None yet
Projects
None yet
Milestone
1.52.x - Release
Development

Successfully merging this pull request may close these issues.

Cleanup Brave Ads
3 participants
@tmancey @wknapik @aseren