Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Brave Ads logs should not show "Failed to initialize...resource" if component updater resource does not exist #18351

Merged
merged 1 commit into from
May 5, 2023

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented May 3, 2023

Resolves brave/brave-browser#21385

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

…if component updater resource does not exist
@tmancey tmancey requested a review from a team as a code owner May 3, 2023 22:09
@tmancey tmancey self-assigned this May 3, 2023
@tmancey tmancey enabled auto-merge May 3, 2023 22:29
@tmancey tmancey merged commit 5f73ad3 into master May 5, 2023
@tmancey tmancey deleted the issues/21385 branch May 5, 2023 16:15
@github-actions github-actions bot added this to the 1.53.x - Nightly milestone May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants