Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cosmetic filtering unhiding heuristic #18425

Merged
merged 3 commits into from
May 12, 2023

Conversation

antonok-edm
Copy link
Collaborator

Resolves brave/brave-browser#30202

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Visit https://dev-pages.bravesoftware.com/filtering/cosmetic-filtering.html and click Run test. The first party elements should be visible, while the third party elements should be hidden.

Switch to Aggressive blocking mode using the Shields panel and re-run the test. All elements should be hidden regardless of partiness.

@antonok-edm antonok-edm self-assigned this May 9, 2023
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label May 9, 2023
@antonok-edm antonok-edm changed the title fix cosmetic filtering unhiding heuristic Fix cosmetic filtering unhiding heuristic May 9, 2023
Copy link
Contributor

@pes10k pes10k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@antonok-edm antonok-edm merged commit 7600528 into master May 12, 2023
@antonok-edm antonok-edm deleted the fix-cosmetic-unhiding-heuristic branch May 12, 2023 06:54
@github-actions github-actions bot added this to the 1.53.x - Nightly milestone May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show first-party subtrees without significant text in default cosmetic filtering mode
3 participants