Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): fix GetTransactionsByStatus for custom chains #18651

Merged
merged 1 commit into from
May 29, 2023

Conversation

onyb
Copy link
Member

@onyb onyb commented May 28, 2023

GetChainId() only takes known networks into consideration, hence transactions of custom chains are never found. As a result, clients are unable to query and display the pending transaction for signing.

Resolves brave/brave-browser#30642

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

The following scenarios should be tested:

  1. As a user I can perform a swap on https://matcha.xyz on the Arbitrum network.
  2. As a user I can see the above transaction (before and after approval) in the transaction history.
    i. With "All networks" dropdown selected.
    ii. With "Arbitrum" dropdown selected.

See linked issue for more details.

@onyb onyb force-pushed the h/wallet/fix-get-transactions branch from c528a76 to 811d579 Compare May 28, 2023 14:15
@onyb onyb merged commit d529cf2 into master May 29, 2023
@onyb onyb deleted the h/wallet/fix-get-transactions branch May 29, 2023 04:33
@github-actions github-actions bot added this to the 1.54.x - Nightly milestone May 29, 2023
brave-builds added a commit that referenced this pull request May 29, 2023
brave-builds added a commit that referenced this pull request May 29, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.54.16 Chromium: 114.0.5735.53 (Official Build) nightly (64-bit)
Revision c499d7ea22c8b2dba278465a5df7b86a8efa4e64-refs/branch-heads/5735@{#970}
OS Linux
  • Verified steps from PR
  • Verified both unapproved and confirmed transactions are listed under activity tab
  • Verified both unapproved and confirmed transactions can be filtered by network
18651.mp4

kjozwiak pushed a commit that referenced this pull request May 30, 2023
kjozwiak pushed a commit that referenced this pull request May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to sign transactions on custom EVM networks
3 participants