Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 116.0.5845.96 to Chromium 116.0.5845.114 (1.58.x). #19831

Merged
merged 4 commits into from
Aug 23, 2023
Merged

Upgrade from Chromium 116.0.5845.96 to Chromium 116.0.5845.114 (1.58.x). #19831

merged 4 commits into from
Aug 23, 2023

Conversation

mkarolin
Copy link
Collaborator

Resolves brave/brave-browser#32451

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin added CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) labels Aug 23, 2023
@mkarolin mkarolin requested a review from a team as a code owner August 23, 2023 03:12
@mkarolin mkarolin self-assigned this Aug 23, 2023
@github-actions github-actions bot added CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) and removed CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) labels Aug 23, 2023
@kjozwiak kjozwiak added this to the 1.58.x - Beta milestone Aug 23, 2023
kjozwiak
kjozwiak approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.58.x approved 👍

@kjozwiak kjozwiak merged commit 17fc3d4 into 1.58.x Aug 23, 2023
5 checks passed
@kjozwiak kjozwiak deleted the 116.0.5845.114_1.58.x branch August 23, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@mkarolin mkarolin

Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-network-audit Run network-audit
Projects
None yet
Milestone
1.58.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@mkarolin @kjozwiak @brave-builds