-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong selected country in rewards #19983
Conversation
@sujitacharya2005 can you check the PR changes on android 7 and android 8 ? we had an issue with spinner for android 7. |
This PR also needs a rebase to resolve failures. |
@sujitacharya2005 were you able to look at : brave/brave-browser#29785 and brave/brave-browser#28399 ? it seems to be affecting the similar changes. |
083bd0c
to
94ed6cd
Compare
@deeppandya |
I checked this in Android 8, it''s working fine. az_recorder_20230922_133319.mp4 |
94ed6cd
to
9a0a3bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
} | ||
return false; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit : formatting
5da402c
to
69433fd
Compare
Auto focus default country Sort all countries including special character
69433fd
to
0aa59ab
Compare
Resolves brave/brave-browser#32273
Resolves brave/brave-browser#28399
Resolves brave/brave-browser#29785
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: