Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong selected country in rewards #19983

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

sujitacharya2005
Copy link
Contributor

@sujitacharya2005 sujitacharya2005 commented Sep 4, 2023

Resolves brave/brave-browser#32273
Resolves brave/brave-browser#28399
Resolves brave/brave-browser#29785

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@sujitacharya2005 sujitacharya2005 added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x86 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 labels Sep 4, 2023
@deeppandya
Copy link
Contributor

@sujitacharya2005 can you check the PR changes on android 7 and android 8 ? we had an issue with spinner for android 7.

@deeppandya
Copy link
Contributor

This PR also needs a rebase to resolve failures.

@deeppandya
Copy link
Contributor

deeppandya commented Sep 18, 2023

@sujitacharya2005 were you able to look at : brave/brave-browser#29785 and brave/brave-browser#28399 ? it seems to be affecting the similar changes.

@sujitacharya2005 sujitacharya2005 force-pushed the 32273_wrong_country_selected branch 2 times, most recently from 083bd0c to 94ed6cd Compare September 21, 2023 22:13
@sujitacharya2005
Copy link
Contributor Author

@sujitacharya2005 were you able to look at : brave/brave-browser#29785 and brave/brave-browser#28399 ? it seems to be affecting the similar changes.

@deeppandya
Updated

@sujitacharya2005
Copy link
Contributor Author

sujitacharya2005 commented Sep 22, 2023

@sujitacharya2005 can you check the PR changes on android 7 and android 8 ? we had an issue with spinner for android 7.

I checked this in Android 8, it''s working fine.
This video is taken in Android-8

az_recorder_20230922_133319.mp4

Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

}
return false;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit : formatting

@sujitacharya2005 sujitacharya2005 force-pushed the 32273_wrong_country_selected branch 2 times, most recently from 5da402c to 69433fd Compare September 25, 2023 09:55
Auto focus default country
Sort all countries including special character
@sujitacharya2005 sujitacharya2005 merged commit 2a8e384 into master Sep 25, 2023
6 checks passed
@sujitacharya2005 sujitacharya2005 deleted the 32273_wrong_country_selected branch September 25, 2023 17:00
@github-actions github-actions bot added this to the 1.60.x - Nightly milestone Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
2 participants