Enable SKUs on Linux by default

[nvonpentz]

Resolves brave/brave-browser#32803

Submitter Checklist:

• I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally:
  • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
  • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

Purchase a Brave News subscription on account.bravesoftware.com. The browser should not crash.

[bsclifton]

LGTM! 😄👍

[nvonpentz]

@fmarier @wknapik I requested your review because of your involvement in brave/brave-browser#23140. I am running Ubuntu and didn't have issues with crashes after these changes.

[wknapik]

@nvonpentz looks like your branch is a major chromium version behind. I'd start with a rebase.

I tested logging into my premium account on latest nightly, without your change, and the browser didn't crash for me.
I also tested using a binary built off your branch and that also didn't crash.

[nvonpentz]

Thanks @wknapik

I tested logging into my premium account on latest nightly, without your change, and the browser didn't crash for me.

Right, I think current master doesn't have crashes, but is also missing support for SKUs (because it was causing crashes). I verified the lack of support by going to brave://skus-internals/, which didn't load until I made this change.

Rebasing.

[bsclifton]

Here's the issue I captured for the crash on Linux:
brave/brave-browser#23348

From my notes there:

I've only been able to reproduce with official build (Nightly for example)

If we wanted to be extra safe, we can do a release build locally WITH PGO profiles. If this doesn't have a crash when logging into account.brave.com then I think we're good to go 🙂 We could always test with Nightly too

If the crash doesn't exist anymore, we can close out brave/brave-browser#23348

[wknapik]

@bsclifton you can use the test pipelines to build any branch (see: wiki)

[nvonpentz]

Based on my own testing locally I am comfortable merging as is and continue testing on Nightly.

[bsclifton]

Let's do it 😄 (once CI passes, of course)

[stephendonner]

Test Plan:

Purchase a Brave News subscription on account.bravesoftware.com. The browser should not crash.

@nvonpentz you mean Brave Talk, Brave Search, or Brave Leo, right?

(And we should definitely test w/Leo.)